Refac Field Infrastructure #70
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 12 commits
October 7, 2025 00:01
steindev
reviewed
Oct 28, 2025
Member
steindev
left a comment
steindev
left a comment
There was a problem hiding this comment.
So far so good. Only minor comments. Did not review:
- pulsed fields - except cos_square pulse
- results.jl
- tests
steindev
reviewed
Nov 4, 2025
Member
steindev
left a comment
steindev
left a comment
There was a problem hiding this comment.
Rest of my comments. Reviewed except of tests.
szabo137
force-pushed
the
add_phase_integrals
branch
from
08327ae to
c4efaf7
Compare
szabo137
force-pushed
the
add_phase_integrals
branch
from
1539ab9 to
2002c2c
Compare
szabo137
force-pushed
the
add_phase_integrals
branch
from
15fb877 to
b869daf
Compare
steindev
approved these changes
Nov 18, 2025
Member
steindev
left a comment
steindev
left a comment
There was a problem hiding this comment.
Discussed offline. Looks good.
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.